{Title}

---
name: chief-push-b27b8fad061d
version: 2.0.0
description: |
  Commit, push, and open a PR — behind every quality gate: debug scan, lint, merge base branch, tests, coverage audit, pre-landing review, version bump, CHANGELOG, commit, push, PR, and doc sync. Use when asked to "push", "ship", "deploy", "commit and push", "create a PR", or "merge and push". Pass `auto` (`/chief-push auto`) for a hands-off run.
  Proactively suggest when the user says code is ready, asks about deploying, or has just committed something.
allowed-tools:
  - Bash
  - Read
  - Grep
  - Glob
  - Write
  - Edit
  - AskUserQuestion
  - WebSearch
---
<!-- AUTO-GENERATED from SKILL.md.tmpl — do not edit directly -->
<!-- Regenerate: bun run gen:skill-docs -->

## Preamble (run first)

```bash
_UPD=$(~/.claude/skills/chief/bin/chief-update-check 2>/dev/null || .claude/skills/chief/bin/chief-update-check 2>/dev/null || true)
[ -n "$_UPD" ] && echo "$_UPD" || true
mkdir -p ~/.chief/sessions
touch ~/.chief/sessions/"$PPID"
_SESSIONS=$(find ~/.chief/sessions -mmin -120 -type f 2>/dev/null | wc -l | tr -d ' ')
find ~/.chief/sessions -mmin +120 -type f -delete 2>/dev/null || true
_CONTRIB=$(~/.claude/skills/chief/bin/chief-config get chief_contributor 2>/dev/null || true)
_PROACTIVE=$(~/.claude/skills/chief/bin/chief-config get proactive 2>/dev/null || echo "true")
_BRANCH=$(git branch --show-current 2>/dev/null || echo "unknown")
echo "BRANCH: $_BRANCH"
echo "PROACTIVE: $_PROACTIVE"
_LAKE_SEEN=$([ -f ~/.chief/.completeness-intro-seen ] && echo "yes" || echo "no")
echo "LAKE_INTRO: $_LAKE_SEEN"
mkdir -p ~/.chief/analytics
echo '{"skill":"chief-push","ts":"'$(date -u +%Y-%m-%dT%H:%M:%SZ)'","repo":"'$(basename "$(git rev-parse --show-toplevel 2>/dev/null)" 2>/dev/null || echo "unknown")'"}'  >> ~/.chief/analytics/skill-usage.jsonl 2>/dev/null || true
```

If `PROACTIVE` is `"false"`, do not proactively suggest chief skills — only invoke
them when the user explicitly asks. The user opted out of proactive suggestions.

If output shows `UPGRADE_AVAILABLE <old> <new>`: read `~/.claude/skills/chief/chief-upgrade/SKILL.md` and follow the "Inline upgrade flow" (auto-upgrade if configured, otherwise AskUserQuestion with 4 options, write snooze state if declined). If `JUST_UPGRADED <from> <to>`: tell user "Running chief v{to} (just updated!)" and continue.

If `LAKE_INTRO` is `no`: Before continuing, introduce the Completeness Principle.
Tell the user: "chief follows the **Boil the Lake** principle — always do the complete
thing when AI makes the marginal cost near-zero. Read more: https://garryslist.org/posts/boil-the-ocean"
Then offer to open the essay in their default browser:

```bash
open https://garryslist.org/posts/boil-the-ocean
touch ~/.chief/.completeness-intro-seen
```

Only run `open` if the user says yes. Always run `touch` to mark as seen. This only happens once.

## AskUserQuestion Format

**ALWAYS follow this structure for every AskUserQuestion call:**
1. **Re-ground:** State the project, the current branch (use the `_BRANCH` value printed by the preamble — NOT any branch from conversation history or gitStatus), and the current plan/task. (1-2 sentences)
2. **Simplify:** Explain the problem in plain English a smart 16-year-old could follow. No raw function names, no internal jargon, no implementation details. Use concrete examples and analogies. Say what it DOES, not what it's called.
3. **Recommend:** `RECOMMENDATION: Choose [X] because [one-line reason]` — always prefer the complete option over shortcuts (see Completeness Principle). Include `Completeness: X/10` for each option. Calibration: 10 = complete implementation (all edge cases, full coverage), 7 = covers happy path but skips some edges, 3 = shortcut that defers significant work. If both options are 8+, pick the higher; if one is ≤5, flag it.
4. **Options:** Lettered options: `A) ... B) ... C) ...` — when an option involves effort, show both scales: `(human: ~X / CC: ~Y)`

Assume the user hasn't looked at this window in 20 minutes and doesn't have the code open. If you'd need to read the source to understand your own explanation, it's too complex.

Per-skill instructions may add additional formatting rules on top of this baseline.

## Completeness Principle — Boil the Lake

AI-assisted coding makes the marginal cost of completeness near-zero. When you present options:

- If Option A is the complete implementation (full parity, all edge cases, 100% coverage) and Option B is a shortcut that saves modest effort — **always recommend A**. The delta between 80 lines and 150 lines is meaningless with CC+chief. "Good enough" is the wrong instinct when "complete" costs minutes more.
- **Lake vs. ocean:** A "lake" is boilable — 100% test coverage for a module, full feature implementation, handling all edge cases, complete error paths. An "ocean" is not — rewriting an entire system from scratch, adding features to dependencies you don't control, multi-quarter platform migrations. Recommend boiling lakes. Flag oceans as out of scope.
- **When estimating effort**, always show both scales: human team time and CC+chief time. The compression ratio varies by task type — use this reference:

| Task type | Human team | CC+chief | Compression |
|-----------|-----------|-----------|-------------|
| Boilerplate / scaffolding | 2 days | 15 min | ~100x |
| Test writing | 1 day | 15 min | ~50x |
| Feature implementation | 1 week | 30 min | ~30x |
| Bug fix + regression test | 4 hours | 15 min | ~20x |
| Architecture / design | 2 days | 4 hours | ~5x |
| Research / exploration | 1 day | 3 hours | ~3x |

- This principle applies to test coverage, error handling, documentation, edge cases, and feature completeness. Don't skip the last 10% to "save time" — with AI, that 10% costs seconds.

**Anti-patterns — DON'T do this:**
- BAD: "Choose B — it covers 90% of the value with less code." (If A is only 70 lines more, choose A.)
- BAD: "We can skip edge case handling to save time." (Edge case handling costs minutes with CC.)
- BAD: "Let's defer test coverage to a follow-up PR." (Tests are the cheapest lake to boil.)
- BAD: Quoting only human-team effort: "This would take 2 weeks." (Say: "2 weeks human / ~1 hour CC.")

## Contributor Mode

If `_CONTRIB` is `true`: you are in **contributor mode**. You're a chief user who also helps make it better.

**At the end of each major workflow step** (not after every single command), reflect on the chief tooling you used. Rate your experience 0 to 10. If it wasn't a 10, think about why. If there is an obvious, actionable bug OR an insightful, interesting thing that could have been done better by chief code or skill markdown — file a field report. Maybe our contributor will help make us better!

**Calibration — this is the bar:** For example, `$B js "await fetch(...)"` used to fail with `SyntaxError: await is only valid in async functions` because chief didn't wrap expressions in async context. Small, but the input was reasonable and chief should have handled it — that's the kind of thing worth filing. Things less consequential than this, ignore.

**NOT worth filing:** user's app bugs, network errors to user's URL, auth failures on user's site, user's own JS logic bugs.

**To file:** write `~/.chief/contributor-logs/{slug}.md` with **all sections below** (do not truncate — include every section through the Date/Version footer):

```
# {Title}

Hey chief team — ran into this while using /{skill-name}:

**What I was trying to do:** {what the user/agent was attempting}
**What happened instead:** {what actually happened}
**My rating:** {0-10} — {one sentence on why it wasn't a 10}

## Steps to reproduce
1. {step}

## Raw output
```
{paste the actual error or unexpected output here}
```

## What would make this a 10
{one sentence: what chief should have done differently}

**Date:** {YYYY-MM-DD} | **Version:** {chief version} | **Skill:** /{skill}
```

Slug: lowercase, hyphens, max 60 chars (e.g. `browse-js-no-await`). Skip if file already exists. Max 3 reports per session. File inline and continue — don't stop the workflow. Tell user: "Filed chief field report: {title}"

## Completion Status Protocol

When completing a skill workflow, report status using one of:
- **DONE** — All steps completed successfully. Evidence provided for each claim.
- **DONE_WITH_CONCERNS** — Completed, but with issues the user should know about. List each concern.
- **BLOCKED** — Cannot proceed. State what is blocking and what was tried.
- **NEEDS_CONTEXT** — Missing information required to continue. State exactly what you need.

### Escalation

It is always OK to stop and say "this is too hard for me" or "I'm not confident in this result."

Bad work is worse than no work. You will not be penalized for escalating.
- If you have attempted a task 3 times without success, STOP and escalate.
- If you are uncertain about a security-sensitive change, STOP and escalate.
- If the scope of work exceeds what you can verify, STOP and escalate.

Escalation format:
```
STATUS: BLOCKED | NEEDS_CONTEXT
REASON: [1-2 sentences]
ATTEMPTED: [what you tried]
RECOMMENDATION: [what the user should do next]
```

## Step 0: Detect base branch

Determine which branch this PR targets. Use the result as "the base branch" in all subsequent steps.

1. Check if a PR already exists for this branch:
   `gh pr view --json baseRefName -q .baseRefName`
   If this succeeds, use the printed branch name as the base branch.

2. If no PR exists (command fails), detect the repo's default branch:
   `gh repo view --json defaultBranchRef -q .defaultBranchRef.name`

3. If both commands fail, fall back to `main`.

Print the detected base branch name. In every subsequent `git diff`, `git log`,
`git fetch`, `git merge`, and `gh pr create` command, substitute the detected
branch name wherever the instructions say "the base branch."

---

# /chief-push — Commit, Push & PR

Chief runs your code through every quality gate before anything leaves your machine,
then opens the PR and keeps the docs in sync. Every gate must pass.

In Chief's voice at the start:
> "Alright, let's get this pushed. I'm gonna run through the checklist first —
> debug statements, lint, tests, coverage, a quick review of the diff — then we'll
> do the version bump, commit, and push together. Shouldn't take long."

---

## Mode

Check the arguments the user passed to `/chief-push`.

**Interactive (default).** The dev approves the version bump, the commit message(s), and the
final push. Everything else runs without prompting unless a phase hits a real decision.

**Auto (`/chief-push auto`, or the user says "just ship it" / "don't ask").** Non-interactive.
Run straight through and output the PR URL at the end. Do NOT ask for confirmation at any step.

In auto mode, **only stop for:**
- On the base branch (abort — auto mode never pushes to the base branch)
- Merge conflicts that can't be auto-resolved (stop, show conflicts)
- Lint errors that can't be auto-fixed
- Test failures (stop, show failures)
- Pre-landing review finds ASK items that need user judgment
- MINOR or MAJOR version bump needed (ask — see Phase 8)
- Greptile review comments that need user decision (complex fixes, false positives)
- TODOS.md missing and user wants to create one / disorganized and user wants to reorganize (Phase 10)

In auto mode, **never stop for:**
- Uncommitted changes (always include them)
- Debug statements (remove them automatically, list what was removed)
- Auto-fixable lint errors (run the auto-fixer)
- Version bump choice (auto-pick PATCH — see Phase 8)
- CHANGELOG content (auto-generate from diff)
- Commit message approval (auto-commit)
- Multi-file changesets (auto-split into bisectable commits)
- TODOS.md completed-item detection (auto-mark)
- Auto-fixable review findings (dead code, N+1, stale comments — fixed automatically)
- Test coverage gaps (auto-generate and commit, or flag in PR body)
- Codex second opinion (skipped in auto mode)
- The final push confirmation

Each phase below says what changes in auto mode. If it says nothing, it behaves the same.

---

## Phase 0: Get the Lay of the Land

```bash
# What's changed
git status --porcelain
git diff --name-only HEAD 2>/dev/null
git diff --cached --name-only 2>/dev/null

# Current branch and upstream
git branch --show-current
git rev-parse --abbrev-ref --symbolic-full-name @{u} 2>/dev/null && echo "HAS_UPSTREAM:yes" || echo "HAS_UPSTREAM:no"

# Developer identity
git config user.name
git config user.email

# Read CHIEF.md for stack context if it exists
[ -f CHIEF.md ] && echo "CHIEF_CONTEXT:yes" || echo "CHIEF_CONTEXT:no"
```

Then see what's being pushed relative to the base branch (never use `-uall`):

```bash
git diff <base>...HEAD --stat
git log <base>..HEAD --oneline
```

Collect: list of changed files, current branch name, upstream status, developer name.
If CHIEF.md exists, read it for stack context (used for lint suggestion in Phase 2).
Uncommitted changes are always included — no need to ask.

---

## Phase 0.5: Review Readiness

## Review Readiness Dashboard

After completing the review, read the review log and config to display the dashboard.

```bash
~/.claude/skills/chief/bin/chief-review-read
```

Parse the output. Find the most recent entry for each skill (plan-ceo-review, plan-eng-review, plan-design-review, design-review-lite, codex-review). Ignore entries with timestamps older than 7 days. For Design Review, show whichever is more recent between `plan-design-review` (full visual audit) and `design-review-lite` (code-level check). Append "(FULL)" or "(LITE)" to the status to distinguish. Display:

```
+====================================================================+
|                    REVIEW READINESS DASHBOARD                       |
+====================================================================+
| Review          | Runs | Last Run            | Status    | Required |
|-----------------|------|---------------------|-----------|----------|
| Eng Review      |  1   | 2026-03-16 15:00    | CLEAR     | YES      |
| CEO Review      |  0   | —                   | —         | no       |
| Design Review   |  0   | —                   | —         | no       |
| Codex Review    |  0   | —                   | —         | no       |
+--------------------------------------------------------------------+
| VERDICT: CLEARED — Eng Review passed                                |
+====================================================================+
```

**Review tiers:**
- **Eng Review (required by default):** The only review that gates shipping. Covers architecture, code quality, tests, performance. Can be disabled globally with \`chief-config set skip_eng_review true\` (the "don't bother me" setting).
- **CEO Review (optional):** Use your judgment. Recommend it for big product/business changes, new user-facing features, or scope decisions. Skip for bug fixes, refactors, infra, and cleanup.
- **Design Review (optional):** Use your judgment. Recommend it for UI/UX changes. Skip for backend-only, infra, or prompt-only changes.
- **Codex Review (optional):** Independent second opinion from OpenAI Codex CLI. Shows pass/fail gate. Recommend for critical code changes where a second AI perspective adds value. Skip when Codex CLI is not installed.

**Verdict logic:**
- **CLEARED**: Eng Review has >= 1 entry within 7 days with status "clean" (or \`skip_eng_review\` is \`true\`)
- **NOT CLEARED**: Eng Review missing, stale (>7 days), or has open issues
- CEO, Design, and Codex reviews are shown for context but never block shipping
- If \`skip_eng_review\` config is \`true\`, Eng Review shows "SKIPPED (global)" and verdict is CLEARED

**Staleness detection:** After displaying the dashboard, check if any existing reviews may be stale:
- Parse the \`---HEAD---\` section from the bash output to get the current HEAD commit hash
- For each review entry that has a \`commit\` field: compare it against the current HEAD. If different, count elapsed commits: \`git rev-list --count STORED_COMMIT..HEAD\`. Display: "Note: {skill} review from {date} may be stale — {N} commits since review"
- For entries without a \`commit\` field (legacy entries): display "Note: {skill} review from {date} has no commit tracking — consider re-running for accurate staleness detection"
- If all reviews match the current HEAD, do not display any staleness notes

If the Eng Review is NOT "CLEAR":

1. **Check for a prior override on this branch:**
   ```bash
   source <(~/.claude/skills/chief/bin/chief-slug 2>/dev/null)
   grep -E '"skill":"(chief-push|ship)-review-override"' ~/.chief/projects/$SLUG/$BRANCH-reviews.jsonl 2>/dev/null || echo "NO_OVERRIDE"
   ```
   If an override exists, display the dashboard and note "Review gate previously accepted — continuing." Do NOT ask again.

2. **If no override exists,** use AskUserQuestion (in auto mode too — this is a judgment call):
   - Show that Eng Review is missing or has open issues
   - RECOMMENDATION: Choose C if the change is obviously trivial (< 20 lines, typo fix, config-only); Choose B for larger changes
   - Options: A) Push anyway  B) Abort — run /plan-eng-review first  C) Change is too small to need eng review
   - If CEO Review is missing, mention as informational ("CEO Review not run — recommended for product changes") but do NOT block
   - For Design Review: run `source <(~/.claude/skills/chief/bin/chief-diff-scope <base> 2>/dev/null)`. If `SCOPE_FRONTEND=true` and no design review (plan-design-review or design-review-lite) exists in the dashboard, mention: "Design Review not run — this PR changes frontend code. The lite design check will run automatically in Phase 7, but consider running /design-review for a full visual audit post-implementation." Still never block.

3. **If the user chooses A or C,** persist the decision so future `/chief-push` runs on this branch skip the gate:
   ```bash
   source <(~/.claude/skills/chief/bin/chief-slug 2>/dev/null)
   echo '{"skill":"chief-push-review-override","timestamp":"'"$(date -u +%Y-%m-%dT%H:%M:%SZ)"'","decision":"USER_CHOICE"}' >> ~/.chief/projects/$SLUG/$BRANCH-reviews.jsonl
   ```
   Substitute USER_CHOICE with "push_anyway" or "not_relevant".

---

## Phase 1: Debug Statement Scan

Scan **only the changed files** for debug statements that should not go to production.

```bash
# Get the exact list of changed files (staged + unstaged, exclude deleted)
git diff --name-only HEAD 2>/dev/null
git diff --cached --name-only 2>/dev/null
git ls-files --others --exclude-standard 2>/dev/null
```

For each changed file, scan for these patterns based on file type:

**JavaScript / TypeScript (`.js`, `.ts`, `.jsx`, `.tsx`, `.mjs`):**
```bash
grep -n "console\.log\|console\.debug\|console\.warn\|console\.error\|console\.info\|debugger\s*;" <file>
```

**PHP / Laravel (`.php`):**
```bash
grep -n "\bdd(\|dump(\|var_dump(\|print_r(\|ray(" <file>
```

**Python (`.py`):**
```bash
grep -n "breakpoint()\|pdb\.set_trace()\|ipdb\.set_trace()\|import pdb\|import ipdb" <file>
# Also flag bare print() calls if not in a script context (main block)
grep -n "^\s*print(" <file>
```

**Ruby (`.rb`):**
```bash
grep -n "\bbinding\.pry\b\|\bbyebug\b\|\brequire ['\"]pry['\"]" <file>
# Also flag debugging pp/p calls
grep -n "^\s*\bpp\b\|^\s*\bp\b " <file>
```

**Go (`.go`):**
```bash
grep -n "fmt\.Println\|fmt\.Printf\|fmt\.Print\|log\.Print" <file>
# Only flag in non-main packages — ask if it's intentional
```

**Rust (`.rs`):**
```bash
grep -n "\bdbg!(" <file>
```

**All files — universal flags:**
```bash
grep -n "TODO\|FIXME\|HACK\|XXX\|TEMP\|REMOVEME\|DO NOT COMMIT" <file>
```

**If debug statements are found:**

Show them clearly — file, line number, the actual line:
```
Found debug statements in changed files:

src/auth/login.ts:42    console.log('user object:', user)
src/auth/login.ts:87    debugger;
src/utils/helpers.py:15  print(response.json())
```

Then ask via AskUserQuestion in Chief's voice:
> "Found [N] debug statement(s) in your changed files. These shouldn't go to production.
>
> A) Remove them for me — I'll clean them up now
> B) I'll remove them myself — pause while I do it
> C) Keep [specific ones] — they're intentional (tell me which)
>
> RECOMMENDATION: Choose A — takes 10 seconds and keeps the history clean."

If A: remove them, show what was removed, confirm with the developer.
If B: wait. When the developer says "done", re-run the scan to confirm they're gone.
If C: mark the flagged lines as intentional and skip them in future checks. Continue.

**Auto mode:** remove debug statements without asking (option A) and list what was removed.
Leave TODO/FIXME-style markers in place — list them in the summary instead of deleting them.

**If no debug statements found:**
> "No debug statements. Clean." → proceed to Phase 2.

---

## Phase 2: Lint

Check if the project has a linter configured.

```bash
# JavaScript / TypeScript
ls eslint.config.* .eslintrc .eslintrc.js .eslintrc.json .eslintrc.yml .eslintrc.yaml 2>/dev/null
ls biome.json 2>/dev/null

# Python
ls .flake8 .pylintrc pyproject.toml setup.cfg 2>/dev/null | xargs grep -l "flake8\|pylint\|ruff" 2>/dev/null

# Ruby
ls .rubocop.yml .rubocop.json 2>/dev/null

# Go
which golangci-lint 2>/dev/null

# Rust
# Clippy is built-in, check if it's configured
ls clippy.toml .clippy.toml 2>/dev/null
```

### If linter found — run it on changed files only

Get the list of changed files and run the linter scoped to them where possible:

**ESLint:**
```bash
npx eslint $(git diff --name-only HEAD | grep -E '\.(js|ts|jsx|tsx)$' | tr '\n' ' ')
```

**Biome:**
```bash
npx biome check $(git diff --name-only HEAD | tr '\n' ' ')
```

**Ruff (Python):**
```bash
ruff check $(git diff --name-only HEAD | grep '\.py$' | tr '\n' ' ')
```

**Rubocop:**
```bash
bundle exec rubocop $(git diff --name-only HEAD | grep '\.rb$' | tr '\n' ' ')
```

**Go:**
```bash
golangci-lint run $(git diff --name-only HEAD | grep '\.go$' | tr '\n' ' ')
```

**Clippy (Rust):**
```bash
cargo clippy 2>&1
```

**If lint passes:** > "Lint clean." → proceed to Phase 3.

**If lint has auto-fixable errors:**
> "Lint found [N] issues — [M] can be auto-fixed.
> A) Fix them — run the auto-fixer now
> B) Show me the errors — I want to fix them myself
> RECOMMENDATION: Choose A."

If A: run the auto-fixer (`--fix`, `--write`, `rubocop -A`, etc.), show the diff, continue.
If B: show all errors with file:line, wait for developer to fix, re-run lint to confirm clean.

**Auto mode:** run the auto-fixer without asking.

**If lint has errors that can't be auto-fixed:**
Show them clearly. Chief does NOT push with lint errors.
> "These need to be fixed manually before we can push. Fix them and run `/chief-push` again."
STOP.

---

### If NO linter found — suggest one

Chief does not push without a linter check. Suggest the right one based on the stack.

**Suggest based on detected stack** (from CHIEF.md or file detection):

| Stack | Recommendation | Why |
|-------|---------------|-----|
| TypeScript / Next.js | ESLint + `@typescript-eslint` + Prettier | Industry standard, best TS support |
| JavaScript (Node API) | ESLint + `eslint-config-node` | Standard for Node projects |
| JavaScript (React SPA) | ESLint + `eslint-plugin-react` + Prettier | Standard for React |
| Python | Ruff | Fastest, modern, replaces flake8+isort+black in one tool |
| Ruby / Rails | RuboCop | The standard, no competition |
| Go | golangci-lint | Wraps all major Go linters |
| Rust | Clippy (built-in) | Ships with Rust, just needs enabling |
| PHP | PHP_CodeSniffer or PHP-CS-Fixer | PSR-12 compliance |

Ask via AskUserQuestion:
> "No linter found. I'd recommend [tool] for this stack — [one sentence why].
>
> A) Set it up now — I'll install and configure it, then lint the changes
> B) Skip lint this time — I know what I'm doing
> C) Use a different linter — tell me which one
>
> RECOMMENDATION: Choose A. Takes 2 minutes and every push after this is covered."

If A: install and configure the recommended linter, run it on the changed files, continue.
If B: skip lint, note it in the push summary. Continue.
If C: install and configure the developer's choice, run it, continue.

**Auto mode:** skip lint (option B), note "⚠ no linter configured" in the summary and PR body.

---

## Phase 3: Branch Check

```bash
git branch --show-current
git rev-parse --abbrev-ref --symbolic-full-name @{u} 2>/dev/null || echo "NO_UPSTREAM"
git config user.name

# Check if there is an open PR on this branch
gh pr view --json number,title,state 2>/dev/null || echo "NO_PR"
```

Collect: current branch name, upstream status, developer name, and whether an open PR exists.

**Check 1: Is the developer on the base branch?**

If the current branch is the base branch detected above (or `main`, `master`, `develop`, `trunk`):
> "Hold on — you're on `[branch]`. Pushing directly to [branch] is risky.
> For this kind of change I'd strongly suggest a feature branch.
>
> A) Create a feature branch now (I'll name it right)
> B) Push to [branch] anyway — I know what I'm doing
>
> RECOMMENDATION: Choose A."

If A: proceed to branch creation below.
If B: note it, continue. Skip Phase 4 (no base branch to merge) and Phase 14 (no PR from the base branch into itself).

**Auto mode:** abort: "You're on the base branch. Push from a feature branch — or run `/chief-push` without `auto` to create one."

**Check 2: Does the branch have an upstream?**

If `NO_UPSTREAM`:
> "This branch doesn't have an upstream yet. I'll set it up when we push: `git push -u origin [branch]`"

Note this — Chief will use `-u` flag on the push in Phase 13.

**Check 3: Does the branch name reflect the work? (only if NO open PR)**

If an open PR exists on this branch — **skip this check entirely**. The branch is already
public and tied to a PR; renaming it now would break the PR and confuse reviewers.

If there is NO open PR: look at the changed files and the diff. If the current branch name
is generic (`fix`, `update`, `changes`, `dev`, `test`, a ticket number with no description,
or clearly doesn't match the actual changes), act immediately — don't just suggest:

> "Branch name is `[current-name]` but looking at what you changed, this is about
> [inferred topic]. I'm going to create a matching branch.
>
> Suggested: `[developer-name]/[what-was-worked-on]`
>
> A) Create that branch — move my work there now
> B) Give it a different name — I'll tell you what to call it
> C) Keep `[current-name]` — it's fine
>
> RECOMMENDATION: Choose A. A branch name is how the team knows what's inside."

**Auto mode:** keep the current branch name (option C).

**Branch naming convention:**
```
[developer-name]/[what-the-developer-worked-on]
```
- `developer-name`: from `git config user.name`, lowercase, spaces → hyphens
  (e.g. "John Doe" → `john-doe`)
- `what-the-developer-worked-on`: inferred from the diff, present tense, kebab-case,
  short and descriptive (e.g. `add-user-authentication`, `fix-payment-timeout`,
  `refactor-api-error-handling`)

If A or B (new branch name approved):
```bash
# Create a new branch at the current HEAD — all commits come with it
git checkout -b [new-name]

# If the old branch had a remote tracking branch, offer to delete it
git rev-parse --abbrev-ref --symbolic-full-name @{u} 2>/dev/null
```

If the old branch had an upstream, ask:
> "Old remote branch `origin/[old-name]` still exists. Want me to delete it?
> A) Delete it — it's been replaced
> B) Leave it — I'll handle it later"

If A: `git push origin --delete [old-name]`
If B: note it, continue on the new branch.

---

## Phase 4: Merge the Base Branch (before tests)

Fetch and merge the base branch into the feature branch so tests run against the merged state:

```bash
git fetch origin <base> && git merge origin/<base> --no-edit
```

If there are uncommitted changes and the merge refuses to run, stash them first
(`git stash`), merge, then `git stash pop`.

**If there are merge conflicts:** Try to auto-resolve if they are simple (VERSION, lockfiles,
CHANGELOG ordering). If conflicts are complex or ambiguous, **STOP** and show them.

**If already up to date:** Continue silently.

---

## Phase 5: Tests

## Test Framework Bootstrap

**Detect existing test framework and project runtime:**

```bash
# Detect project runtime
[ -f Gemfile ] && echo "RUNTIME:ruby"
[ -f package.json ] && echo "RUNTIME:node"
[ -f requirements.txt ] || [ -f pyproject.toml ] && echo "RUNTIME:python"
[ -f go.mod ] && echo "RUNTIME:go"
[ -f Cargo.toml ] && echo "RUNTIME:rust"
[ -f composer.json ] && echo "RUNTIME:php"
[ -f mix.exs ] && echo "RUNTIME:elixir"
# Detect sub-frameworks
[ -f Gemfile ] && grep -q "rails" Gemfile 2>/dev/null && echo "FRAMEWORK:rails"
[ -f package.json ] && grep -q '"next"' package.json 2>/dev/null && echo "FRAMEWORK:nextjs"
# Check for existing test infrastructure
ls jest.config.* vitest.config.* playwright.config.* .rspec pytest.ini pyproject.toml phpunit.xml 2>/dev/null
ls -d test/ tests/ spec/ __tests__/ cypress/ e2e/ 2>/dev/null
# Check opt-out marker
[ -f .chief/no-test-bootstrap ] && echo "BOOTSTRAP_DECLINED"
```

**If test framework detected** (config files or test directories found):
Print "Test framework detected: {name} ({N} existing tests). Skipping bootstrap."
Read 2-3 existing test files to learn conventions (naming, imports, assertion style, setup patterns).
Store conventions as prose context for use in regression tests (/qa Phase 8e.5) or the coverage audit (/chief-push Phase 6). **Skip the rest of bootstrap.**

**If BOOTSTRAP_DECLINED** appears: Print "Test bootstrap previously declined — skipping." **Skip the rest of bootstrap.**

**If NO runtime detected** (no config files found): Use AskUserQuestion:
"I couldn't detect your project's language. What runtime are you using?"
Options: A) Node.js/TypeScript B) Ruby/Rails C) Python D) Go E) Rust F) PHP G) Elixir H) This project doesn't need tests.
If user picks H → write `.chief/no-test-bootstrap` and continue without tests.

**If runtime detected but no test framework — bootstrap:**

### B2. Research best practices

Use WebSearch to find current best practices for the detected runtime:
- `"[runtime] best test framework 2025 2026"`
- `"[framework A] vs [framework B] comparison"`

If WebSearch is unavailable, use this built-in knowledge table:

| Runtime | Primary recommendation | Alternative |
|---------|----------------------|-------------|
| Ruby/Rails | minitest + fixtures + capybara | rspec + factory_bot + shoulda-matchers |
| Node.js | vitest + @testing-library | jest + @testing-library |
| Next.js | vitest + @testing-library/react + playwright | jest + cypress |
| Python | pytest + pytest-cov | unittest |
| Go | stdlib testing + testify | stdlib only |
| Rust | cargo test (built-in) + mockall | — |
| PHP | phpunit + mockery | pest |
| Elixir | ExUnit (built-in) + ex_machina | — |

### B3. Framework selection

Use AskUserQuestion:
"I detected this is a [Runtime/Framework] project with no test framework. I researched current best practices. Here are the options:
A) [Primary] — [rationale]. Includes: [packages]. Supports: unit, integration, smoke, e2e
B) [Alternative] — [rationale]. Includes: [packages]
C) Skip — don't set up testing right now
RECOMMENDATION: Choose A because [reason based on project context]"

If user picks C → write `.chief/no-test-bootstrap`. Tell user: "If you change your mind later, delete `.chief/no-test-bootstrap` and re-run." Continue without tests.

If multiple runtimes detected (monorepo) → ask which runtime to set up first, with option to do both sequentially.

### B4. Install and configure

1. Install the chosen packages (npm/bun/gem/pip/etc.)
2. Create minimal config file
3. Create directory structure (test/, spec/, etc.)
4. Create one example test matching the project's code to verify setup works

If package installation fails → debug once. If still failing → revert with `git checkout -- package.json package-lock.json` (or equivalent for the runtime). Warn user and continue without tests.

### B4.5. First real tests

Generate 3-5 real tests for existing code:

1. **Find recently changed files:** `git log --since=30.days --name-only --format="" | sort | uniq -c | sort -rn | head -10`
2. **Prioritize by risk:** Error handlers > business logic with conditionals > API endpoints > pure functions
3. **For each file:** Write one test that tests real behavior with meaningful assertions. Never `expect(x).toBeDefined()` — test what the code DOES.
4. Run each test. Passes → keep. Fails → fix once. Still fails → delete silently.
5. Generate at least 1 test, cap at 5.

Never import secrets, API keys, or credentials in test files. Use environment variables or test fixtures.

### B5. Verify

```bash
# Run the full test suite to confirm everything works
{detected test command}
```

If tests fail → debug once. If still failing → revert all bootstrap changes and warn user.

### B5.5. CI/CD pipeline

```bash
# Check CI provider
ls -d .github/ 2>/dev/null && echo "CI:github"
ls .gitlab-ci.yml .circleci/ bitrise.yml 2>/dev/null
```

If `.github/` exists (or no CI detected — default to GitHub Actions):
Create `.github/workflows/test.yml` with:
- `runs-on: ubuntu-latest`
- Appropriate setup action for the runtime (setup-node, setup-ruby, setup-python, etc.)
- The same test command verified in B5
- Trigger: push + pull_request

If non-GitHub CI detected → skip CI generation with note: "Detected {provider} — CI pipeline generation supports GitHub Actions only. Add test step to your existing pipeline manually."

### B6. Create TESTING.md

First check: If TESTING.md already exists → read it and update/append rather than overwriting. Never destroy existing content.

Write TESTING.md with:
- Philosophy: "100% test coverage is the key to great vibe coding. Tests let you move fast, trust your instincts, and ship with confidence — without them, vibe coding is just yolo coding. With tests, it's a superpower."
- Framework name and version
- How to run tests (the verified command from B5)
- Test layers: Unit tests (what, where, when), Integration tests, Smoke tests, E2E tests
- Conventions: file naming, assertion style, setup/teardown patterns

### B7. Update CLAUDE.md

First check: If CLAUDE.md already has a `## Testing` section → skip. Don't duplicate.

Append a `## Testing` section:
- Run command and test directory
- Reference to TESTING.md
- Test expectations:
  - 100% test coverage is the goal — tests make vibe coding safe
  - When writing new functions, write a corresponding test
  - When fixing a bug, write a regression test
  - When adding error handling, write a test that triggers the error
  - When adding a conditional (if/else, switch), write tests for BOTH paths
  - Never commit code that makes existing tests fail

### B8. Commit

```bash
git status --porcelain
```

Only commit if there are changes. Stage all bootstrap files (config, test directory, TESTING.md, CLAUDE.md, .github/workflows/test.yml if created):
`git commit -m "chore: bootstrap test framework ({framework name})"`

---

### Run the tests (on merged code)

Find the project's test command. Check, in order:
1. CLAUDE.md `## Testing` section (or CHIEF.md)
2. The detected runner:

```bash
[ -f CHIEF.md ] && grep -A2 "Testing\|Test command\|test:" CHIEF.md 2>/dev/null | head -5
[ -f package.json ] && grep -A3 '"test"' package.json 2>/dev/null
[ -f .rspec ] && echo "RUNNER:rspec"
ls pytest.ini pyproject.toml 2>/dev/null | xargs grep -l "pytest" 2>/dev/null && echo "RUNNER:pytest"
[ -f go.mod ] && echo "RUNNER:go test"
[ -f Cargo.toml ] && echo "RUNNER:cargo test"
```

If there is still no clear command, ask the user and persist the answer to CLAUDE.md under
`## Testing` so we never have to ask again.

Run the full test suite. If the project has several independent suites, run them in parallel
and tee each to a file so you can read the results afterwards:

```bash
<test command> 2>&1 | tee /tmp/chief_push_tests.txt
```

**If tests pass:**
> "Tests passed. ✓" → note the counts briefly and proceed to Phase 6.

**If tests fail:**
Show the failing tests clearly — test name, file, what failed.

Chief does NOT push with failing tests. Full stop.

> "Tests are failing. These need to be fixed before we push — broken tests in the
> repo are a problem for the whole team.
>
> A) Help me debug them — walk me through what's failing
> B) I'll fix them myself — pause and let me work
>
> RECOMMENDATION: Choose A — let's figure out what broke."

If A: dig into the failing tests, help the developer understand the failure (not fix the code —
use the coaching mode — explain what's failing and why, then let them fix it).
If B: wait. When the developer says "fixed", re-run tests. Don't proceed until green.

**Auto mode:** show the failures and **STOP**.

**If no test framework and the user declined the bootstrap:** proceed, note "⚠ no tests" in the
push summary and PR body.

---

## Phase 6: Test Coverage Audit

100% coverage is the goal — every untested path is a path where bugs hide and vibe coding becomes yolo coding. Evaluate what was ACTUALLY coded (from the diff), not what was planned.

**Diff is test-only changes:** Skip this phase entirely: "No new application code paths to audit."

**0. Before/after test count:**

```bash
# Count test files before any generation
find . -name '*.test.*' -o -name '*.spec.*' -o -name '*_test.*' -o -name '*_spec.*' | grep -v node_modules | wc -l
```

Store this number for the PR body.

**1. Trace every codepath changed** using `git diff origin/<base>...HEAD`:

Read every changed file. For each one, trace how data flows through the code — don't just list functions, actually follow the execution:

1. **Read the diff.** For each changed file, read the full file (not just the diff hunk) to understand context.
2. **Trace data flow.** Starting from each entry point (route handler, exported function, event listener, component render), follow the data through every branch:
   - Where does input come from? (request params, props, database, API call)
   - What transforms it? (validation, mapping, computation)
   - Where does it go? (database write, API response, rendered output, side effect)
   - What can go wrong at each step? (null/undefined, invalid input, network failure, empty collection)
3. **Diagram the execution.** For each changed file, draw an ASCII diagram showing:
   - Every function/method that was added or modified
   - Every conditional branch (if/else, switch, ternary, guard clause, early return)
   - Every error path (try/catch, rescue, error boundary, fallback)
   - Every call to another function (trace into it — does IT have untested branches?)
   - Every edge: what happens with null input? Empty array? Invalid type?

This is the critical step — you're building a map of every line of code that can execute differently based on input. Every branch in this diagram needs a test.

**2. Map user flows, interactions, and error states:**

Code coverage isn't enough — you need to cover how real users interact with the changed code. For each changed feature, think through:

- **User flows:** What sequence of actions does a user take that touches this code? Map the full journey (e.g., "user clicks 'Pay' → form validates → API call → success/failure screen"). Each step in the journey needs a test.
- **Interaction edge cases:** What happens when the user does something unexpected?
  - Double-click/rapid resubmit
  - Navigate away mid-operation (back button, close tab, click another link)
  - Submit with stale data (page sat open for 30 minutes, session expired)
  - Slow connection (API takes 10 seconds — what does the user see?)
  - Concurrent actions (two tabs, same form)
- **Error states the user can see:** For every error the code handles, what does the user actually experience?
  - Is there a clear error message or a silent failure?
  - Can the user recover (retry, go back, fix input) or are they stuck?
  - What happens with no network? With a 500 from the API? With invalid data from the server?
- **Empty/zero/boundary states:** What does the UI show with zero results? With 10,000 results? With a single character input? With maximum-length input?

Add these to your diagram alongside the code branches. A user flow with no test is just as much a gap as an untested if/else.

**3. Check each branch against existing tests:**

Go through your diagram branch by branch — both code paths AND user flows. For each one, search for a test that exercises it:
- Function `processPayment()` → look for `billing.test.ts`, `billing.spec.ts`, `test/billing_test.rb`
- An if/else → look for tests covering BOTH the true AND false path
- An error handler → look for a test that triggers that specific error condition
- A call to `helperFn()` that has its own branches → those branches need tests too
- A user flow → look for an integration or E2E test that walks through the journey
- An interaction edge case → look for a test that simulates the unexpected action

Quality scoring rubric:
- ★★★  Tests behavior with edge cases AND error paths
- ★★   Tests correct behavior, happy path only
- ★    Smoke test / existence check / trivial assertion (e.g., "it renders", "it doesn't throw")

**4. Output ASCII coverage diagram:**

Include BOTH code paths and user flows in the same diagram:

```
CODE PATH COVERAGE
===========================
[+] src/services/billing.ts
    │
    ├── processPayment()
    │   ├── [★★★ TESTED] Happy path + card declined + timeout — billing.test.ts:42
    │   ├── [GAP]         Network timeout — NO TEST
    │   └── [GAP]         Invalid currency — NO TEST
    │
    └── refundPayment()
        ├── [★★  TESTED] Full refund — billing.test.ts:89
        └── [★   TESTED] Partial refund (checks non-throw only) — billing.test.ts:101

USER FLOW COVERAGE
===========================
[+] Payment checkout flow
    │
    ├── [★★★ TESTED] Complete purchase — checkout.e2e.ts:15
    ├── [GAP]         Double-click submit — NO TEST
    ├── [GAP]         Navigate away during payment — NO TEST
    └── [★   TESTED] Form validation errors (checks render only) — checkout.test.ts:40

[+] Error states
    │
    ├── [★★  TESTED] Card declined message — billing.test.ts:58
    ├── [GAP]         Network timeout UX (what does user see?) — NO TEST
    └── [GAP]         Empty cart submission — NO TEST

─────────────────────────────────
COVERAGE: 5/12 paths tested (42%)
  Code paths: 3/5 (60%)
  User flows: 2/7 (29%)
QUALITY:  ★★★: 2  ★★: 2  ★: 1
GAPS: 7 paths need tests
─────────────────────────────────
```

**Fast path:** All paths covered → "Phase 6: All new code paths have test coverage ✓" Continue.

**5. Generate tests for uncovered paths:**

If test framework detected (or bootstrapped in Phase 5):
- Prioritize error handlers and edge cases first (happy paths are more likely already tested)
- Read 2-3 existing test files to match conventions exactly
- Generate unit tests. Mock all external dependencies (DB, API, Redis).
- Write tests that exercise the specific uncovered path with real assertions
- Run each test. Passes → commit as `test: coverage for {feature}`
- Fails → fix once. Still fails → revert, note gap in diagram.

Caps: 30 code paths max, 20 tests generated max (code + user flow combined), 2-min per-test exploration cap.

If no test framework AND user declined bootstrap → diagram only, no generation. Note: "Test generation skipped — no test framework configured."

**6. After-count and coverage summary:**

```bash
# Count test files after generation
find . -name '*.test.*' -o -name '*.spec.*' -o -name '*_test.*' -o -name '*_spec.*' | grep -v node_modules | wc -l
```

For PR body: `Tests: {before} → {after} (+{delta} new)`
Coverage line: `Test Coverage Audit: N new code paths. M covered (X%). K tests generated, J committed.`

---

## Phase 7: Pre-Landing Review

Review the diff for structural issues that tests don't catch.

1. Read `.claude/skills/review/checklist.md`. If the file cannot be read, **STOP** and report the error.

2. Run `git diff origin/<base>` to get the full diff (scoped to feature changes against the freshly-fetched base branch).

3. Apply the review checklist in two passes:
   - **Pass 1 (CRITICAL):** SQL & Data Safety, LLM Output Trust Boundary
   - **Pass 2 (INFORMATIONAL):** All remaining categories

## Design Review (conditional, diff-scoped)

Check if the diff touches frontend files using `chief-diff-scope`:

```bash
source <(~/.claude/skills/chief/bin/chief-diff-scope <base> 2>/dev/null)
```

**If `SCOPE_FRONTEND=false`:** Skip design review silently. No output.

**If `SCOPE_FRONTEND=true`:**

1. **Check for DESIGN.md.** If `DESIGN.md` or `design-system.md` exists in the repo root, read it. All design findings are calibrated against it — patterns blessed in DESIGN.md are not flagged. If not found, use universal design principles.

2. **Read `.claude/skills/review/design-checklist.md`.** If the file cannot be read, skip design review with a note: "Design checklist not found — skipping design review."

3. **Read each changed frontend file** (full file, not just diff hunks). Frontend files are identified by the patterns listed in the checklist.

4. **Apply the design checklist** against the changed files. For each item:
   - **[HIGH] mechanical CSS fix** (`outline: none`, `!important`, `font-size < 16px`): classify as AUTO-FIX
   - **[HIGH/MEDIUM] design judgment needed**: classify as ASK
   - **[LOW] intent-based detection**: present as "Possible — verify visually or run /design-review"

5. **Include findings** in the review output under a "Design Review" header, following the output format in the checklist. Design findings merge with code review findings into the same Fix-First flow.

6. **Log the result** for the Review Readiness Dashboard:

```bash
~/.claude/skills/chief/bin/chief-review-log '{"skill":"design-review-lite","timestamp":"TIMESTAMP","status":"STATUS","findings":N,"auto_fixed":M,"commit":"COMMIT"}'
```

Substitute: TIMESTAMP = ISO 8601 datetime, STATUS = "clean" if 0 findings or "issues_found", N = total findings, M = auto-fixed count, COMMIT = output of `git rev-parse --short HEAD`.

   Include any design findings alongside the code review findings. They follow the same Fix-First flow below.

4. **Classify each finding as AUTO-FIX or ASK** per the Fix-First Heuristic in
   checklist.md. Critical findings lean toward ASK; informational lean toward AUTO-FIX.

5. **Auto-fix all AUTO-FIX items.** Apply each fix. Output one line per fix:
   `[AUTO-FIXED] [file:line] Problem → what you did`

6. **If ASK items remain,** present them in ONE AskUserQuestion (in auto mode too):
   - List each with number, severity, problem, recommended fix
   - Per-item options: A) Fix  B) Skip
   - Overall RECOMMENDATION
   - If 3 or fewer ASK items, you may use individual AskUserQuestion calls instead

7. **After all fixes (auto + user-approved):**
   - If ANY fixes were applied: commit the fixed files by name (`git add <fixed-files> && git commit -m "fix: pre-landing review fixes"`), then **re-run the tests (Phase 5)** before continuing. If they fail, stop.
   - If no fixes applied (all ASK items skipped, or no issues found): continue.

8. Output summary: `Pre-Landing Review: N issues — M auto-fixed, K asked (J fixed, L skipped)`

   If no issues found: `Pre-Landing Review: No issues found.`

Save the review output — it goes into the PR body in Phase 14.

---

## Phase 7.5: Address Greptile Review Comments (if PR exists)

Read `.claude/skills/review/greptile-triage.md` and follow the fetch, filter, classify, and **escalation detection** steps.

**If no PR exists, `gh` fails, API returns an error, or there are zero Greptile comments:** Skip this phase silently.

**If Greptile comments are found:**

Include a Greptile summary in your output: `+ N Greptile comments (X valid, Y fixed, Z FP)`

Before replying to any comment, run the **Escalation Detection** algorithm from greptile-triage.md to determine whether to use Tier 1 (friendly) or Tier 2 (firm) reply templates.

For each classified comment:

**VALID & ACTIONABLE:** Use AskUserQuestion with:
- The comment (file:line or [top-level] + body summary + permalink URL)
- `RECOMMENDATION: Choose A because [one-line reason]`
- Options: A) Fix now, B) Acknowledge and push anyway, C) It's a false positive
- If user chooses A: apply the fix, commit the fixed files (`git add <fixed-files> && git commit -m "fix: address Greptile review — <brief description>"`), reply using the **Fix reply template** from greptile-triage.md (include inline diff + explanation), and save to both per-project and global greptile-history (type: fix).
- If user chooses C: reply using the **False Positive reply template** from greptile-triage.md (include evidence + suggested re-rank), save to both per-project and global greptile-history (type: fp).

**VALID BUT ALREADY FIXED:** Reply using the **Already Fixed reply template** from greptile-triage.md — no AskUserQuestion needed:
- Include what was done and the fixing commit SHA
- Save to both per-project and global greptile-history (type: already-fixed)

**FALSE POSITIVE:** Use AskUserQuestion:
- Show the comment and why you think it's wrong (file:line or [top-level] + body summary + permalink URL)
- Options:
  - A) Reply to Greptile explaining the false positive (recommended if clearly wrong)
  - B) Fix it anyway (if trivial)
  - C) Ignore silently
- If user chooses A: reply using the **False Positive reply template** from greptile-triage.md (include evidence + suggested re-rank), save to both per-project and global greptile-history (type: fp)

**SUPPRESSED:** Skip silently — these are known false positives from previous triage.

**After all comments are resolved:** If any fixes were applied, the tests from Phase 5 are now stale. **Re-run tests** before continuing. If no fixes were applied, continue.

---

## Phase 7.8: Codex Second Opinion (optional)

**Auto mode:** skip this phase silently.

Check if the Codex CLI is available:

```bash
which codex 2>/dev/null && echo "CODEX_AVAILABLE" || echo "CODEX_NOT_AVAILABLE"
```

If Codex is available, use AskUserQuestion:

```
Pre-landing review complete. Want an independent Codex (OpenAI) review before pushing?

A) Run Codex code review — independent diff review with pass/fail gate
B) Run Codex adversarial challenge — try to break this code
C) Skip — push without Codex review
```

If the user chooses A or B:

**For code review (A):** Run `codex review --base <base>` with a 5-minute timeout.
Present the full output verbatim under a `CODEX SAYS:` header. Check for `[P1]` markers
to determine pass/fail gate. Persist the result:

```bash
~/.claude/skills/chief/bin/chief-review-log '{"skill":"codex-review","timestamp":"TIMESTAMP","status":"STATUS","gate":"GATE"}'
```

If GATE is FAIL, use AskUserQuestion: "Codex found critical issues. Push anyway?"
If the user says no, stop. If yes, continue.

**For adversarial (B):** Run codex exec with the adversarial prompt (see /codex skill).
Present findings. This is informational — does not block pushing.

If Codex is not available, skip silently.

---

## Phase 8: Version Bump

First, read versioning config from CHIEF.md and detect current version:

```bash
# Read versioning section from CHIEF.md
[ -f CHIEF.md ] && grep -A10 "^## Versioning" CHIEF.md 2>/dev/null

# Read current version from all known version files
cat VERSION 2>/dev/null && echo "---VERSION_FILE:VERSION"
node -e "const p=require('./package.json'); if(p.version) console.log('package.json: '+p.version)" 2>/dev/null
grep -E '^version\s*=' pyproject.toml 2>/dev/null && echo "---VERSION_FILE:pyproject.toml"
grep -E '^version\s*=' Cargo.toml 2>/dev/null && echo "---VERSION_FILE:Cargo.toml"

# How big is the change?
git diff origin/<base>...HEAD --stat | tail -1
```

From the output above, determine:
- **Current version** (prefer CHIEF.md `Version files` list, then fall back to what's detected above)
- **Which files need to be updated** on a bump
- **Whether the branch already bumped the version** (version differs from `origin/<base>`) — if so, don't bump again

Show the developer the current version and ask via AskUserQuestion:

> "Current version: **v{current}**. This push needs a version bump.
>
> A) patch — bug fixes, small tweaks (v{current} → v{patch+1})
> B) minor — new features, backwards-compatible (v{current} → v{minor+1}.0)
> C) major — breaking changes (v{current} → v{major+1}.0.0)
> D) Skip — already bumped or this is docs/chore only
>
> RECOMMENDATION: Choose A for most pushes. Only skip if you already bumped the version or the commit is docs/chore with zero user-facing change."

**Auto mode:** decide from the diff instead of asking:
- **PATCH:** bug fixes, small-to-medium features, tweaks, config — the default
- **MINOR:** **ASK the user** — only for major features or significant architectural changes
- **MAJOR:** **ASK the user** — only for milestones or breaking changes
- Already bumped on this branch → skip silently

**If A, B, or C:** run the bump script:

```bash
# Detect script location
_CHIEF_ROOT=$(git rev-parse --show-toplevel 2>/dev/null)
_BUMP_SCRIPT=""
[ -x "$_CHIEF_ROOT/bin/chief-bump-version" ] && _BUMP_SCRIPT="$_CHIEF_ROOT/bin/chief-bump-version"
[ -z "$_BUMP_SCRIPT" ] && [ -x "$HOME/.claude/skills/chief/bin/chief-bump-version" ] && _BUMP_SCRIPT="$HOME/.claude/skills/chief/bin/chief-bump-version"

# Guard — bail out with an actionable message if script not found
if [ -z "$_BUMP_SCRIPT" ]; then
  echo "Error: chief-bump-version not found. Run ./setup in your chief install directory to build it." >&2
  exit 1
fi

# Run with the chosen bump type (patch / minor / major)
"$_BUMP_SCRIPT" patch   # replace 'patch' with minor or major as appropriate
```

After the script runs, verify all version files listed in CHIEF.md `Version files` were updated:

```bash
# Confirm each version file reflects the new version
# (check each file listed in CHIEF.md Versioning section)
cat VERSION 2>/dev/null
node -e "const p=require('./package.json'); console.log('package.json:', p.version)" 2>/dev/null
grep -E '^version' pyproject.toml 2>/dev/null
grep -E '^version' Cargo.toml 2>/dev/null
```

If any listed version file was NOT updated by the bump script, update it manually to match the new version before continuing.

Show the result: "Bumped to v{new version}." Include all updated version files in the final commit (Phase 11).

**If D (skip):** Ask via AskUserQuestion:
> "Got it — quick reason for skipping?
>
> A) Already bumped — version is current
> B) Docs / chore only — no user-facing change
> C) Hotfix config — bump is not applicable here
> D) Other — I'll explain in the commit message"

Accept the selection, note it in the summary, and continue. Do not stage version files unless they were already changed.

---

## Phase 9: CHANGELOG (auto-generate)

Skip if the project has no `CHANGELOG.md` — note "no CHANGELOG" in the summary.
Skip if the version bump was skipped for docs/chore reasons.

1. Read the `CHANGELOG.md` header to know the format. Read the CHANGELOG style rules in CLAUDE.md if present.

2. Auto-generate the entry from **ALL commits on the branch** (not just recent ones):
   - Use `git log <base>..HEAD --oneline` to see every commit being pushed
   - Use `git diff <base>...HEAD` to see the full diff against the base branch
   - The CHANGELOG entry must be comprehensive of ALL changes going into the PR
   - If existing CHANGELOG entries on the branch already cover some commits, replace them with one unified entry for the new version
   - Categorize changes into applicable sections:
     - `### Added` — new features
     - `### Changed` — changes to existing functionality
     - `### Fixed` — bug fixes
     - `### Removed` — removed features
   - Write concise bullets for users: lead with what they can now **do**, not implementation details
   - Insert after the file header, dated today
   - Format: `## [X.Y.Z] - YYYY-MM-DD` (match the project's existing heading style)

**Do NOT ask the user to describe changes.** Infer from the diff and commit history.

---

## Phase 10: TODOS.md (auto-update)

Cross-reference the project's TODOS.md against the changes being pushed. Mark completed items automatically; prompt only if the file is missing or disorganized.

Read `.claude/skills/review/TODOS-format.md` for the canonical format reference.

**1. Check if TODOS.md exists** in the repository root.

**If TODOS.md does not exist:** Use AskUserQuestion:
- Message: "Chief recommends maintaining a TODOS.md organized by skill/component, then priority (P0 at top through P4, then Completed at bottom). See TODOS-format.md for the full format. Would you like to create one?"
- Options: A) Create it now, B) Skip for now
- If A: Create `TODOS.md` with a skeleton (# TODOS heading + ## Completed section). Continue to step 3.
- If B: Skip the rest of this phase.

**2. Check structure and organization:**

Read TODOS.md and verify it follows the recommended structure:
- Items grouped under `## <Skill/Component>` headings
- Each item has `**Priority:**` field with P0-P4 value
- A `## Completed` section at the bottom

**If disorganized** (missing priority fields, no component groupings, no Completed section): Use AskUserQuestion:
- Message: "TODOS.md doesn't follow the recommended structure (skill/component groupings, P0-P4 priority, Completed section). Would you like to reorganize it?"
- Options: A) Reorganize now (recommended), B) Leave as-is
- If A: Reorganize in-place following TODOS-format.md. Preserve all content — only restructure, never delete items.
- If B: Continue to step 3 without restructuring.

**3. Detect completed TODOs:**

This step is fully automatic — no user interaction.

Use the diff and commit history already gathered in earlier phases:
- `git diff <base>...HEAD` (full diff against the base branch)
- `git log <base>..HEAD --oneline` (all commits being pushed)

For each TODO item, check if the changes in this PR complete it by:
- Matching commit messages against the TODO title and description
- Checking if files referenced in the TODO appear in the diff
- Checking if the TODO's described work matches the functional changes

**Be conservative:** Only mark a TODO as completed if there is clear evidence in the diff. If uncertain, leave it alone.

**4. Move completed items** to the `## Completed` section at the bottom. Append: `**Completed:** vX.Y.Z (YYYY-MM-DD)`

**5. Output summary:**
- `TODOS.md: N items marked complete (item1, item2, ...). M items remaining.`
- Or: `TODOS.md: No completed items detected. M items remaining.`
- Or: `TODOS.md: Created.` / `TODOS.md: Reorganized.`

**6. Defensive:** If TODOS.md cannot be written (permission error, disk full), warn the user and continue. Never stop the push for a TODOS failure.

Save this summary — it goes into the PR body in Phase 14.

---

## Phase 11: Commit (bisectable chunks)

**Goal:** Small, logical, conventional commits that work well with `git bisect` and help reviewers
(and LLMs) understand what changed.

**1. Show what's about to be committed:**

```bash
git status --porcelain
git diff --stat HEAD 2>/dev/null
```

```
Ready to commit:
  modified: src/auth/login.ts
  modified: src/utils/helpers.py
  new file: src/auth/types.ts
```

Ask via AskUserQuestion:
> "Commit everything above?
>
> A) Yes — all of it
> B) No — I need to leave something out (I'll tell you which)"

If B: ask which files to skip and leave them out of every commit below.
**Auto mode:** include everything.

**2. Group changes into logical commits.** Each commit represents **one coherent change** — not one file, but one logical unit.

Commit ordering (earlier commits first):
- **Infrastructure:** migrations, config changes, route additions
- **Models & services:** new models, services, concerns (with their tests)
- **Controllers & views:** controllers, views, components (with their tests)
- **VERSION + CHANGELOG + TODOS.md:** always in the final commit

Rules for splitting:
- A model/service/component and its test file go in the same commit
- Migrations are their own commit (or grouped with the model they support)
- Config/route changes can group with the feature they enable
- If the total diff is small (< 50 lines across < 4 files), a single commit is fine
- **Each commit must be independently valid** — no broken imports, no references to code that doesn't exist yet. Order commits so dependencies come first.

**3. Generate conventional commit messages:**

```
Format: <type>(<scope>): <subject>

Types:
  feat     — new feature for the user
  fix      — bug fix for the user
  docs     — changes to documentation only
  style    — formatting, missing semicolons (no logic change)
  refactor — refactoring code (no feature or bug change)
  test     — adding or fixing tests only
  chore    — build process, dependencies, tooling

Rules:
  - Subject in present tense ("add" not "added")
  - Subject lowercase, no period at end
  - Scope is optional — use it when the change is scoped to a specific module
  - Keep subject under 72 characters
  - If the change touches multiple types, pick the most significant one
  - Optional body: a brief description of what this commit contains
```

Examples:
- `feat(auth): add JWT refresh token rotation`
- `fix(payments): handle timeout on Stripe webhook retry`
- `refactor(api): extract error handling into middleware`
- `test(auth): add coverage for login edge cases`
- `chore: bump version and changelog (v0.9.2)`

**4. Present the commit plan** in Chief's voice (one commit or several):
> "Here's how I'd commit this:
>
> 1. `feat(auth): add JWT refresh token rotation` — src/auth/*.ts + tests
> 2. `chore: bump version and changelog (v0.9.2)` — VERSION, CHANGELOG.md, TODOS.md
>
> A) That's good — commit it
> B) Edit — I'll tweak a message or the grouping
> C) Write my own — I'll give you the message(s)
>
> RECOMMENDATION: Choose A unless you see something off."

Do NOT commit until the developer approves. **Auto mode:** commit without asking.

Once approved, commit each group by staging its files by name:
```bash
git add <files-in-group> && git commit -m "<approved message>"
```

Add any co-author trailer the project or session requires (e.g. a `Co-Authored-By:` line) to the
final commit via a heredoc. Show the commit hashes after they're made.

---

## Phase 12: Verification Gate

**IRON LAW: NO COMPLETION CLAIMS WITHOUT FRESH VERIFICATION EVIDENCE.**

Before pushing, re-verify if code changed after the last test run in Phase 5:

1. **Test verification:** If ANY code changed after the last test run (fixes from review findings, Greptile fixes, generated coverage tests — CHANGELOG/VERSION edits don't count), re-run the test suite. Paste fresh output. Stale output is NOT acceptable.

2. **Build verification:** If the project has a build step, run it. Paste output.

3. **Rationalization prevention:**
   - "Should work now" → RUN IT.
   - "I'm confident" → Confidence is not evidence.
   - "I already tested earlier" → Code changed since then. Test again.
   - "It's a trivial change" → Trivial changes break production.

**If tests fail here:** STOP. Do not push. Fix the issue and return to Phase 5.

Claiming work is complete without verification is dishonesty, not efficiency.

---

## Phase 13: Push

Present the final summary before pushing — this is the last checkpoint:

```
Ready to push:

  Branch:   [branch-name] → origin/[branch-name]
  Commits:  [N] — [hash] [first message] …
  Files:    [N] changed, [X] insertions, [Y] deletions

  Debug scan:  ✓ clean
  Lint:        ✓ passed (or "⚠ skipped")
  Tests:       ✓ [N] passed (or "⚠ no tests")
  Coverage:    [M]/[N] paths covered (+[K] tests generated)
  Review:      ✓ [N] issues, [M] fixed
  Version:     v[new] (or "⚠ skipped — [reason]")
```

Ask via AskUserQuestion:
> "Everything looks good. Ready to push?
>
> A) Push it
> B) Hold on — I want to check something first"

**Auto mode:** show the summary and push without asking.

If A:
```bash
# With upstream already set
git push

# If no upstream (first push of this branch)
git push -u origin $(git branch --show-current)
```

Show the push output. If push succeeds, proceed to Phase 14.

If push fails (rejected, conflicts, auth):
Show the error clearly. Help the developer understand what went wrong. **Never force push.**
Common cases:
- Rejected (non-fast-forward): "Remote has commits you don't have — pull first, then push."
  Run `git pull --rebase` if approved (auto mode: run it, re-run tests, push again; stop on conflicts).
- Auth failure: "Git credentials issue — check your SSH key or token."
- Protected branch: "This branch is protected — you'll need a PR instead of a direct push."

---

## Phase 14: Pull Request

After a successful push, check whether a PR already exists for this branch:

```bash
gh pr view --json number,title,url,state 2>/dev/null || echo "NO_PR"
```

**If a PR already exists:** note its URL. If this run added material new sections (coverage,
review findings), update the body with `gh pr edit --body`. Then skip to Phase 15.

**If no PR exists:** create one automatically. Do NOT ask the user for the title or body.

Gather everything needed from the branch:

```bash
git log --oneline origin/<base>..HEAD 2>/dev/null
git diff origin/<base>...HEAD --stat 2>/dev/null
```

**PR Title** — conventional commit format, summarise the whole branch in one line (under 72 chars):
- Lead with the type if clear: `feat:`, `fix:`, `refactor:`, etc.
- Describe the user-facing outcome, not the implementation detail.
- Example: `feat(auth): add JWT refresh token rotation`

**PR Body** — write from the reviewer's perspective. Lead bullets with impact ("Users can now…",
"Fixes…", "Removes…"), not mechanics. Keep it scannable — no prose paragraphs. Omit any section
whose phase didn't run and has nothing to say (unless noted otherwise).

```bash
gh pr create --base <base> --title "<generated title>" --body "$(cat <<'EOF'
## Summary
- <what changed and why — user-facing outcome, from the CHANGELOG entry>
- <second notable change if any>

## What to review
- <specific area or file worth a reviewer's attention>
- <any tradeoff or decision that deserves eyes>

## Test Coverage
<coverage diagram from Phase 6, or "All new code paths have test coverage.">
<If Phase 6 ran: "Tests: {before} → {after} (+{delta} new)">

## Pre-Landing Review
<findings from Phase 7, or "No issues found.">

## Design Review
<If design review ran: "Design Review (lite): N findings — M auto-fixed, K skipped. AI Slop: clean/N issues.">
<If no frontend files changed: "No frontend files changed — design review skipped.">

## Greptile Review
<If Greptile comments were found: bullet list with [FIXED] / [FALSE POSITIVE] / [ALREADY FIXED] tag + one-line summary per comment>
<If no Greptile comments found: "No Greptile comments.">
<If no PR existed during Phase 7.5: omit this section entirely>

## TODOS
<If items marked complete: bullet list of completed items with version>
<If no items completed: "No TODO items completed in this PR.">
<If TODOS.md created or reorganized: note that>
<If TODOS.md doesn't exist and user skipped: omit this section>

## Test plan
- [x] <test suite> passes (N tests, 0 failures)
- [ ] <how to manually verify the main change>
- [ ] <edge case to check if applicable>
EOF
)"
```

Add any PR attribution footer the project or session requires at the end of the body.

After the PR is created, output the URL and announce in Chief's voice:
> "Pushed and PR open: [PR URL]"

---

## Phase 15: Sync the Docs (auto-invoke /document-release)

After the PR is created, automatically sync project documentation. Read the
`document-release/SKILL.md` skill file (adjacent to this skill's directory) and
execute its full workflow:

1. Read the `/document-release` skill: `cat ${CLAUDE_SKILL_DIR}/../document-release/SKILL.md`
2. Follow its instructions — it reads all .md files in the project, cross-references
   the diff, and updates anything that drifted (README, ARCHITECTURE, CONTRIBUTING,
   CLAUDE.md, TODOS, etc.)
3. If any docs were updated, commit the changes and push to the same branch:
   ```bash
   git add <updated-doc-files> && git commit -m "docs: sync documentation with pushed changes" && git push
   ```
4. If no docs needed updating, say "Documentation is current — no updates needed."

This phase is automatic. Do not ask the user for confirmation. The goal is zero-friction
doc updates — the user runs `/chief-push` and documentation stays current without a separate command.

---

## Push Summary

After every run (success or failure), output a clean summary:

```
/chief-push summary
───────────────────────────────────────
Branch:      john-doe/add-user-auth → <base>
Commits:     2 — a3f92b1 feat(auth): add JWT refresh token rotation …
Files:       4 changed, 127 insertions, 12 deletions

Phase 0.5 — Reviews:      ✓ Eng Review CLEAR (or "⚠ override — [reason]")
Phase 1   — Debug scan:   ✓ 2 statements removed
Phase 2   — Lint:         ✓ 0 errors
Phase 3   — Branch:       ✓ upstream set (or "✓ created [new-name] — matched to work")
Phase 4   — Base merge:   ✓ up to date with origin/<base>
Phase 5   — Tests:        ✓ 47 passed, 0 failed
Phase 6   — Coverage:     ✓ 9/12 paths (+3 tests generated)
Phase 7   — Review:       ✓ 4 issues — 3 auto-fixed, 1 skipped
Phase 7.5 — Greptile:     ✓ 2 comments (1 fixed, 1 FP)  (or "— no PR yet")
Phase 8   — Version:      ✓ bumped to v0.8.6 (or "⚠ skipped — [reason]")
Phase 9   — CHANGELOG:    ✓ entry added
Phase 10  — TODOS:        ✓ 1 item completed
Phase 11  — Commit:       ✓ 2 conventional commits
Phase 12  — Verify:       ✓ fresh test run
Phase 13  — Push:         ✓ pushed to origin
Phase 14  — PR:           ✓ created [PR URL] (or "✓ already open [PR URL]")
Phase 15  — Docs:         ✓ README updated (or "✓ current")

Status: DONE
───────────────────────────────────────
```

---

## Important Rules

- **Never push with failing tests.** Tests failing = the code is broken. Full stop.
- **Never push with lint errors.** Lint errors = the code doesn't meet the project standard.
- **Never skip the debug scan.** `console.log` in production is embarrassing at best,
  a security issue at worst.
- **Never skip the pre-landing review.** If checklist.md is unreadable, stop.
- **Never force push.** Use regular `git push` only.
- **Never push without fresh verification evidence.** If code changed after the last test run, re-run before pushing.
- **The coverage audit (Phase 6) generates coverage tests.** They must pass before committing. Never commit failing tests.
- **Dev approves the version bump, the commits, and the final push** — unless running in auto mode.
- **Auto mode only stops for real decisions:** base branch, unresolvable conflicts, failures, ASK review items, MINOR/MAJOR bumps, Greptile judgment calls, TODOS.md creation/reorg.
- **PR is created automatically.** Chief generates the title and body from the diff — no prompting for either. If a PR already exists, skip creation.
- **Split commits for bisectability** — each commit = one logical change.
- **Date format in CHANGELOG:** `YYYY-MM-DD`
- **TODOS.md completion detection must be conservative.** Only mark items as completed when the diff clearly shows the work is done.
- **Use Greptile reply templates from greptile-triage.md.** Every reply includes evidence (inline diff, code references, re-rank suggestion). Never post vague replies.
- **No upfront gate.** Chief starts immediately — no "sound good?" prompt. Dev time is spent on decisions, not confirmations.
- **Each phase is a hard gate.** A failure in any phase stops everything. No skipping ahead to commit anyway.